[ 
https://issues.apache.org/jira/browse/HBASE-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268682#comment-13268682
 ] 

stack commented on HBASE-5889:
------------------------------

I took a look.  Its good.  I tried changing RegionServerUtil so it was package 
private but I got these failures which are odd given the class is named 
RegionServerUtil.  What you reckon?

{code}
[INFO] Compilation failure

/Users/Stack/checkouts/trunk/src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java:[43,43]
 org.apache.hadoop.hbase.regionserver.RegionServerUtil is not public in 
org.apache.hadoop.hbase.regionserver; cannot be accessed from outside package

/Users/Stack/checkouts/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:[79,43]
 org.apache.hadoop.hbase.regionserver.RegionServerUtil is not public in 
org.apache.hadoop.hbase.regionserver; cannot be accessed from outside package

/Users/Stack/checkouts/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java:[72,43]
 org.apache.hadoop.hbase.regionserver.RegionServerUtil is not public in 
org.apache.hadoop.hbase.regionserver; cannot be accessed from outside package

/Users/Stack/checkouts/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java:[70,43]
 org.apache.hadoop.hbase.regionserver.RegionServerUtil is not public in 
org.apache.hadoop.hbase.regionserver; cannot be accessed from outside package

/Users/Stack/checkouts/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java:[55,43]
 org.apache.hadoop.hbase.regionserver.RegionServerUtil is not public in 
org.apache.hadoop.hbase.regionserver; cannot be accessed from outside package
{code}

What are these classes making use of RegionServerUtil?
                
> Remove HRegionInterface
> -----------------------
>
>                 Key: HBASE-5889
>                 URL: https://issues.apache.org/jira/browse/HBASE-5889
>             Project: HBase
>          Issue Type: Improvement
>          Components: client, ipc, regionserver
>    Affects Versions: 0.96.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: hbase-5889_v3.patch, hbase_5889.patch, 
> hbase_5889_v2.patch
>
>
> As a step to move internals to PB, so as to avoid the conversion for 
> performance reason, we should remove the HRegionInterface. 
> Therefore region server only supports ClientProtocol and AdminProtocol.  
> Later on, HRegion can work with PB messages directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to