wchevreuil commented on a change in pull request #2430:
URL: https://github.com/apache/hbase/pull/2430#discussion_r492588627
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java
##########
@@ -63,7 +121,7 @@ protected synchronized void disconnect() {
* A private method used to re-establish a zookeeper session with a peer
cluster.
* @param ke
*/
- protected void reconnect(KeeperException ke) {
+ private void reconnect(KeeperException ke) {
Review comment:
> So if one user want to use these logics, it is better to copy these
code to their implementation.
It's not that simple, as it would actually require reimplement all other
methods currently referring these private ones, leading to a reimplementation
of the whole class.
I agree with @Apache9 , if we are to guarantee a certain level of
accessibility here, we should rather discuss about the interfaces audiences. I
guess this would be rather a topic for a separate jira/PR, don't want to
deviate this current one from it's original purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
