taklwu commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r494741081
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -304,6 +306,10 @@ function check_needed_vars {
return 0
}
+function is_svn_ci_disabled {
+ [[ "$DRY_RUN" = 1 ]] || [[ "$IGNORE_SVN_CI" = 1 ]]
Review comment:
why can't we just use `dry-run`/ no `-f` ? seems like they're doing the
same thing, please correct me if I'm missing something.
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -304,6 +306,10 @@ function check_needed_vars {
return 0
}
+function is_svn_ci_disabled {
+ [[ "$DRY_RUN" = 1 ]] || [[ "$IGNORE_SVN_CI" = 1 ]]
Review comment:
(reworded) is this change for using `-ignore-svn-ci` with `-f` together?
it does not seem like we can use it without `dry-run`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
