pankaj72981 commented on a change in pull request #2353:
URL: https://github.com/apache/hbase/pull/2353#discussion_r497698404
##########
File path:
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestColumnFamilyDescriptorBuilder.java
##########
@@ -181,4 +181,39 @@ public void testSetTimeToLive() throws HBaseException {
builder.setTimeToLive(ttl);
Assert.assertEquals(43282800, builder.build().getTimeToLive());
}
+
+ @Test
+ public void testDefaultBuilder() {
+ /*
+ Test for verifying the ColumnFamilyDescriptorBuilder's default values
so that backward
+ compatibility with hbase-1.x can be mantained (see HBASE-24981).
+ */
Review comment:
Changes looks fine, few nit comments
1. Test case description should be moved at test method level.
2. Extract `ColumnFamilyDescriptorBuilder.getDefaultValues()` and reuse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
