virajjasani commented on a change in pull request #2494:
URL: https://github.com/apache/hbase/pull/2494#discussion_r499151407



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java
##########
@@ -57,7 +58,7 @@
 
   // Specify specific regions of a table to reopen.
   // if specified null, all regions of the table will be reopened.
-  private final List<byte[]> regionNames;
+  private List<byte[]> regionNames;

Review comment:
       Basically, if `regionNames` is null or empty, then we will reopen all 
regions. Only if the list contains at least one regionName, we will reopen only 
those regions specified in list.
   
   Corresponding logic is 
[here](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java#L173):
   ```
       if (CollectionUtils.isNotEmpty(regionNames) &&
         CollectionUtils.isNotEmpty(tableRegionsForReopen)) {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to