[ 
https://issues.apache.org/jira/browse/HBASE-25115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207307#comment-17207307
 ] 

Viraj Jasani commented on HBASE-25115:
--------------------------------------

[~niuyulin] [~zcq_rambo] I just realized that we have 2 PRs: one for master and 
another for branch-2.2, both from different authors.

Usually, only Jira assignee creates PR and we create PR for just master branch 
as long as the patch is not huge and patch is not significantly different 
across multiple release branches. For now it's fine, will merge both PRs after 
some time. Also, master PR has test, so let me include that for branch-2.2 
commit also.

Thanks to both of you for finding and fixing this nice bug.

> HFilePrettyPrinter can't seek to the row which is the first row of a hfile
> --------------------------------------------------------------------------
>
>                 Key: HBASE-25115
>                 URL: https://issues.apache.org/jira/browse/HBASE-25115
>             Project: HBase
>          Issue Type: Bug
>          Components: HFile, tooling
>    Affects Versions: 2.2.6
>            Reporter: Chaoqiang Zhong
>            Assignee: niuyulin
>            Priority: Major
>         Attachments: HBASE-25115.patch
>
>
> This issue can be reproduced by below steps:
>  * make a hfile contains two rows '000' and '001';
> {code:java}
> D:\bin>hbase hfile -p -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 000/f1:a/1601282789548/Put/vlen=4/seqid=4 V: aaaa
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5 V: aaaa
> Scanned kv count -> 2{code}
>  * '001' can be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 001 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5
> Scanned kv count -> 1{code}
>  * but '000' can't be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 000 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> Scanned kv count -> 0{code}
>  In HFilePrettyPrinter we use 
> "scanner.seekTo(PrivateCellUtil.createFirstOnRow(this.row))" to seek to 
> row.But this method will retrurn -1 when the row is the first row of hfile.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to