virajjasani commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r500199740
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ########## @@ -371,7 +358,11 @@ private boolean skipForMerge(final RegionStates regionStates, final RegionInfo r final long nextSizeMb = getRegionSizeMB(next); // always merge away empty regions when they present themselves. if (currentSizeMb == 0 || nextSizeMb == 0 || currentSizeMb + nextSizeMb < avgRegionSizeMb) { - plans.add(new MergeNormalizationPlan(current, next)); + final MergeNormalizationPlan plan = new MergeNormalizationPlan.Builder() + .addTarget(current, currentSizeMb) + .addTarget(next, nextSizeMb) Review comment: Sure this is not normalizer's job to validate but by keeping target regions as list, we might keep odd no of regions a while just to abandon them later by `MergeTableRegionsProcedure#checkRegionsToMerge` if we keep it unbounded list. How about `List<Pair<NormalizerRegionInfo, NormalizerRegionInfo>>` as target regions in `MergeNormalizationPlan`? `NormalizerRegionInfo` can just contain `regionInfo` and `regionSize`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org