saintstack commented on a change in pull request #2506:
URL: https://github.com/apache/hbase/pull/2506#discussion_r501431187
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
##########
@@ -429,7 +429,6 @@ private boolean hasFamilyQualifierPermission(User user,
DELETE("delete"),
CHECK_AND_PUT("checkAndPut"),
CHECK_AND_DELETE("checkAndDelete"),
- INCREMENT_COLUMN_VALUE("incrementColumnValue"),
Review comment:
This is not used anymore? Is this feature no longer in place?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
##########
@@ -1695,32 +1703,6 @@ public Result
preAppend(ObserverContext<RegionCoprocessorEnvironment> c, Append
return null;
}
- @Override
Review comment:
Not used any more?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
##########
@@ -1756,32 +1738,6 @@ public Result preIncrement(final
ObserverContext<RegionCoprocessorEnvironment> c
return null;
}
- @Override
- public Result preIncrementAfterRowLock(final
ObserverContext<RegionCoprocessorEnvironment> c,
Review comment:
Ditto?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
