Apache9 commented on a change in pull request #2513:
URL: https://github.com/apache/hbase/pull/2513#discussion_r502722982



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1157,13 +1188,6 @@ private void 
finishActiveMasterInitialization(MonitoredTask status) throws IOExc
     }
 
     assignmentManager.checkIfShouldMoveSystemRegionAsync();
-    status.setStatus("Assign meta replicas");
-    MasterMetaBootstrap metaBootstrap = createMetaBootstrap();
-    try {
-      metaBootstrap.assignMetaReplicas();
-    } catch (IOException | KeeperException e){
-      LOG.error("Assigning meta replica failed: ", e);
-    }

Review comment:
       Yes, in general we do not need this any more. All the works should be 
done in MTP. The only exception is that we still need to be compatible with the 
old way so we have a special logic when starting master, to schedule a MTP if 
the META_REPLICA_NUM has been changed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to