[ https://issues.apache.org/jira/browse/HBASE-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270126#comment-13270126 ]
jirapos...@reviews.apache.org commented on HBASE-5935: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5060/ ----------------------------------------------------------- (Updated 2012-05-08 01:34:20.873632) Review request for hbase, Michael Stack and Jimmy Xiang. Changes ------- Update against newest trunk and added some additional error checking. Summary ------- Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign, unassign). I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number? This addresses bug HBASE-5935. https://issues.apache.org/jira/browse/HBASE-5935 Diffs (updated) ----- src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547 src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119 src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 5d4be3f src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a5e03e1 src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION src/main/protobuf/Master.proto PRE-CREATION src/main/protobuf/RegionServerStatus.proto 9d7728f src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java e5de603 src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 83297cc Diff: https://reviews.apache.org/r/5060/diff Testing ------- Thanks, Gregory > Add Region-level PB-based calls to HMasterInterface > --------------------------------------------------- > > Key: HBASE-5935 > URL: https://issues.apache.org/jira/browse/HBASE-5935 > Project: HBase > Issue Type: Task > Components: ipc, master, migration > Reporter: Gregory Chanan > Assignee: Gregory Chanan > Fix For: 0.96.0 > > > This should be a subtask of HBASE-5445, but since that is a subtask, I can't > also make this a subtask (apparently). > This is for converting the region-level calls, i.e.: > moveRegion > assignRegion > unassignRegion -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira