[ https://issues.apache.org/jira/browse/HBASE-25156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211712#comment-17211712 ]
Duo Zhang commented on HBASE-25156: ----------------------------------- Seems the test is broken instead of flaky? It fails 100% now... > TestMasterFailover.testSimpleMasterFailover is flaky > ----------------------------------------------------- > > Key: HBASE-25156 > URL: https://issues.apache.org/jira/browse/HBASE-25156 > Project: HBase > Issue Type: Test > Components: test > Affects Versions: 3.0.0-alpha-1 > Reporter: Nick Dimiduk > Assignee: Nick Dimiduk > Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.3, 1.7.0, 2.4.0, 2.2.7 > > > {noformat} > [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: > 32.996 s <<< FAILURE! - in org.apache.hadoop.hbase.master.TestMasterFailover > [ERROR] > org.apache.hadoop.hbase.master.TestMasterFailover.testSimpleMasterFailover > Time elapsed: 12.317 s <<< FAILURE! > java.lang.AssertionError: expected:<1> but was:<2> > at > org.apache.hadoop.hbase.master.TestMasterFailover.testSimpleMasterFailover(TestMasterFailover.java:133) > {noformat} > Looks like this test depends on metrics to be updated as a source of > side-effect used to verify the test. Seems like it should retry the check a > few times, or maybe we need a last-updated monotonic value that the test can > check before and after it expects a change to be visible. -- This message was sent by Atlassian Jira (v8.3.4#803005)