Apache9 commented on a change in pull request #2521:
URL: https://github.com/apache/hbase/pull/2521#discussion_r503889463
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -691,6 +691,9 @@ public void terminate(String reason, Exception cause,
boolean clearMetrics,
}
}
+ if (this.replicationEndpoint != null) {
Review comment:
I think the intenion here to interrupt thread first is that, we want to
make sure that, we could still do replication when shutting down the worker.
In general, I'm fine with this approach as in distributed system, we should
have the ability to deal with this type error. But it is still a bit strange
that, the above stop worker and setReaderRunning to false can not stop the work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
