huaxiangsun commented on pull request #2522: URL: https://github.com/apache/hbase/pull/2522#issuecomment-710482867
> First, the issue number is incorrect, it should be HBASE-25125, not HBASE-25215. Thanks Duo, will correct. > > What I concern here is that, this is only an enhancement right? The RegionReplicaReplicationEndpoint could also be used to replicate meta edits? The only disadvantage is that, the speed will be slowed down if there is a slow replica, but I do not think it is a blocker for meta replica? Could we make the meta replicas feature work first so we can merge HBASE-18070 back and then let's do the enhancement? Yeah, agreed here. Client side work is in progress, that is the reason, review comments from Stack has not been addressed in this week. > And in general, I do not like that we have a specialized implementation for meta replica inside the region replica framework. They are almost the same so they should share the same code base. I think this enhancement could also be applied to normal RegionReplicaReplicationEndpoint, what we need is the config for the max distance between different secondary replicas. For normal region replicas, the value will be small, which means we will soon block the replication if any replicas are slow, to save memory. For meta replicas, we could have a large default value to let the good replicas catch up fast. > Anyway, my biggest concern here is that, this is not a blocker to prevent us merge HBASE-18070 back, as people said we want this feature in 2.4, we'd better focus on other blocker issues, such as how to let client go to secondary meta replicas as much as possible. Feel free to correct me if I'm wrong. I moved your comments in the design doc, we put some thoughts there already, happy to continue the discussion there. https://docs.google.com/document/d/1jJWVc-idHhhgL4KDRpjMsQJKCl_NRaCLGiH3Wqwd3O8/edit#heading=h.8n622lgkwlai ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
