[ 
https://issues.apache.org/jira/browse/HBASE-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270682#comment-13270682
 ] 

stack commented on HBASE-5806:
------------------------------

bq. So can we add cases for RS_ZK_SPLIT* conditions with a log message with 
debug level. Because this is expected. If we have WARN, it may attract 
unnecessary attention. And have one default case again with a log message with 
WARN level?

Yes.  Add cases for RS_ZK_SPLIT* and log at DEBUG level that these callbacks 
are just passing through (or do not log if this is 'normal' operation).  Yes, I 
agree, logging at WARN level will make users think this an abnormal state which 
is not what we want them to think.

I would then restore the default case throwing IllegalStateException rather 
than log a WARN.  Now your change is more focused on addressing the issue found 
by Chinna.  Previous, the patch could catch illegal states that were other than 
RS_ZK_SPLIT*
                
> Handle split region related failures on master restart and RS restart
> ---------------------------------------------------------------------
>
>                 Key: HBASE-5806
>                 URL: https://issues.apache.org/jira/browse/HBASE-5806
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Chinna Rao Lalam
>             Fix For: 0.92.2, 0.96.0, 0.94.1
>
>         Attachments: HBASE-5806.patch, HBASE-5806_0.92.patch, 
> HBASE-5806_0.94.patch, HBASE-5806_0.94_1.patch, HBASE-5806_0.94_2.patch, 
> HBASE-5806_trunk.patch, HBASE-5806_trunk_1.patch, HBASE-5806_trunk_2.patch
>
>
> This issue is raised to solve issues that comes out of partial region split 
> happened and the region node in the ZK which is in RS_ZK_REGION_SPLITTING and 
> RS_ZK_REGION_SPLIT is not yet processed.
> This also tries to address HBASE-5615.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to