[ https://issues.apache.org/jira/browse/HBASE-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270694#comment-13270694 ]
stack commented on HBASE-5958: ------------------------------ Looks like adding protostuff could help elsewhere; it looks like we can generate classes as part of the build w/o having to rely on external pb compiler being on the build path. Shouldn't we do data dictionary whether protostuff or not? Seems like a generally good idea (tm) > Replace ByteString.copyFrom with new ByteString() > ------------------------------------------------- > > Key: HBASE-5958 > URL: https://issues.apache.org/jira/browse/HBASE-5958 > Project: HBase > Issue Type: Improvement > Components: performance > Affects Versions: 0.96.0 > Reporter: Jimmy Xiang > Assignee: Jimmy Xiang > Fix For: 0.96.0 > > > ByteString.copyFrom makes a copy of a byte array in case it is changed in > other thread. > In most case, we don't need to worry about that. We should avoid copying the > bytes > for performance issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira