infraio commented on a change in pull request #2568:
URL: https://github.com/apache/hbase/pull/2568#discussion_r509243675
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -5324,22 +5328,25 @@ private long replayRecoveredEditsForPaths(long
minSeqIdForTheRegion, FileSystem
}
private void handleException(FileSystem fs, Path edits, IOException e)
throws IOException {
- boolean skipErrors =
conf.getBoolean(HConstants.HREGION_EDITS_REPLAY_SKIP_ERRORS,
- conf.getBoolean("hbase.skip.errors",
HConstants.DEFAULT_HREGION_EDITS_REPLAY_SKIP_ERRORS));
- if (conf.get("hbase.skip.errors") != null) {
- LOG.warn("The property 'hbase.skip.errors' has been deprecated. Please
use "
- + HConstants.HREGION_EDITS_REPLAY_SKIP_ERRORS + " instead.");
- }
- if (skipErrors) {
+ if (isSkipErrorEnabled()) {
Path p = WALSplitUtil.moveAsideBadEditsFile(fs, edits);
- LOG.error(HConstants.HREGION_EDITS_REPLAY_SKIP_ERRORS + "=true so
continuing. Renamed "
- + edits + " as " + p,
- e);
+ LOG.info(
Review comment:
LOG not right? Seems hbase.skip.errors=true may got here too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
