apurtell commented on a change in pull request #2574:
URL: https://github.com/apache/hbase/pull/2574#discussion_r512089577
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -688,14 +688,17 @@ void sawNoSuchFamily() {
// Last flush time for each Store. Useful when we are flushing for each
column
private final ConcurrentMap<HStore, Long> lastStoreFlushTimeMap = new
ConcurrentHashMap<>();
- final RegionServerServices rsServices;
+ protected RegionServerServices rsServices;
Review comment:
In the HRegion tests I mock RSS with mockito, to test if the HRegion
code calls RSS#abort as it should. We don't need to make a real cluster test
that aborts a server (and adds a lot of time to the unit test suite) just to
confirm this. So, it needs to be nonfinal for mocking, but it does not need to
be exposed as a settable thing, because nowhere else in the code is there a use
for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
