ramkrish86 commented on a change in pull request #2582:
URL: https://github.com/apache/hbase/pull/2582#discussion_r517919646
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/SizeCachedKeyValue.java
##########
@@ -39,12 +39,22 @@
private short rowLen;
private int keyLen;
- public SizeCachedKeyValue(byte[] bytes, int offset, int length, long seqId) {
+ public SizeCachedKeyValue(byte[] bytes, int offset, int length, long seqId,
int keyLen) {
super(bytes, offset, length);
// We will read all these cached values at least once. Initialize now
itself so that we can
// avoid uninitialized checks with every time call
- rowLen = super.getRowLength();
- keyLen = super.getKeyLength();
+ this.rowLen = super.getRowLength();
Review comment:
I tried this actually but from the this() constructor calling the
super.getRowLength is not allowed. Hence I went with this simple way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
