infraio commented on a change in pull request #1994: URL: https://github.com/apache/hbase/pull/1994#discussion_r522675608
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java ########## @@ -541,7 +541,11 @@ public TableDescriptorBuilder setReplicationScope(int scope) { } public TableDescriptorBuilder setRegionServerGroup(String group) { - desc.setValue(RSGROUP_KEY, new Bytes(Bytes.toBytes(group))); + if (group == null) { Review comment: How to unset RSGroup by shell? Add a unit test for shell too? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org