anoopsjohn commented on a change in pull request #2706:
URL: https://github.com/apache/hbase/pull/2706#discussion_r534641294
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
##########
@@ -2015,7 +2015,8 @@ public static void toIOException(ServiceException se)
throws IOException {
kvbuilder.setTimestamp(kv.getTimestamp());
kvbuilder.setValue(wrap(((ByteBufferExtendedCell)
kv).getValueByteBuffer(),
((ByteBufferExtendedCell) kv).getValuePosition(),
kv.getValueLength()));
- // TODO : Once tags become first class then we may have to set tags to
kvbuilder.
+ kvbuilder.setTags(wrap(((ByteBufferExtendedCell) kv).getTagsByteBuffer(),
Review comment:
Sorry for being late. I know this is already merged. But I have a
concern here. I think you changed here because Export uses this for
serialization. But in a scan/get RPC call, when it is issued by a client
which do not support CellBlock encoding, we will use this API instead of the KV
codec to send back results. So in such cases, we are ending up exposing Tags
back to client (All tags). This is against our thinking and design.
cc @virajjasani
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
