[ 
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243312#comment-17243312
 ] 

Viraj Jasani commented on HBASE-25246:
--------------------------------------

RSRpcServices has this logic:
{code:java}
if (clientCellBlockSupported) {
  for (Result res : results) {
    builder.addCellsPerResult(res.size());
    builder.addPartialFlagPerResult(res.mayHaveMoreCellsInRow());
  }
  controller.setCellScanner(CellUtil.createCellScanner(results));
} else {
  for (Result res : results) {
    ClientProtos.Result pbr = ProtobufUtil.toResult(res);
    builder.addResults(pbr);
  }
}

{code}
Hence, if client doesn't have cellBlock supported, we go to 
ProtobufUtil.toResult(final Result result), which internally calls 
ProtobufUtil.toCell(final Cell kv) and hence, kvbuilder.setTags() (as per PR 
#2706) is executed.

> Backup/Restore hbase cell tags.
> -------------------------------
>
>                 Key: HBASE-25246
>                 URL: https://issues.apache.org/jira/browse/HBASE-25246
>             Project: HBase
>          Issue Type: Improvement
>          Components: backup&restore
>            Reporter: Rushabh Shah
>            Assignee: Rushabh Shah
>            Priority: Major
>             Fix For: 3.0.0-alpha-1, 2.2.7, 2.3.4, 2.5.0, 2.4.1
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After 
> having a discussion with hbase community via dev mailing thread, it was 
> decided that we will pass the tags via an attribute in Mutation object and 
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 
> is to store metadata in Delete marker so that while running Restore tool we 
> can selectively restore certain Delete markers and ignore others. For that to 
> happen we need to persist these tags in Backup and retrieve them in Restore 
> MR jobs (Import/Export tool). 
> Currently we don't persist the tags in Backup. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to