sunhelly commented on a change in pull request #2657:
URL: https://github.com/apache/hbase/pull/2657#discussion_r536992653
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDeadServer.java
##########
@@ -104,15 +93,15 @@ public static void tearDownAfterClass() throws Exception {
}
@Test
- public void testCrashProcedureReplay() {
+ public void testCrashProcedureReplay() throws IOException {
HMaster master = TEST_UTIL.getHBaseCluster().getMaster();
final ProcedureExecutor<MasterProcedureEnv> pExecutor =
master.getMasterProcedureExecutor();
ServerCrashProcedure proc = new ServerCrashProcedure(
pExecutor.getEnvironment(), hostname123, false, false);
ProcedureTestingUtility.submitAndWait(pExecutor, proc);
-
assertFalse(master.getServerManager().getDeadServers().areDeadServersInProgress());
Review comment:
This test case should assert false, because the SCP has been done
completely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
