shahrs87 commented on a change in pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#discussion_r537131913
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/RawCell.java
##########
@@ -64,4 +65,19 @@ public static void checkForTagsLength(int tagsLength) {
throw new IllegalArgumentException("tagslength " + tagsLength + " > " +
MAX_TAGS_LENGTH);
}
}
+
+ /**
+ * @return A new cell which is having the extra tags also added to it.
+ */
+ public static Cell createCell(Cell cell, List<Tag> tags) {
+ return PrivateCellUtil.createCell(cell, tags);
+ }
+
+ /**
+ * @param cell The Cell
+ * @return Tags in the given Cell as a List
+ */
+ public static List<Tag> getTags(Cell cell) {
Review comment:
We are exposing RawCell#createCell(Cell cell, List<Tag> tags) in this
patch which accepts list of Tags.
So I thought it would be more user friendly to have some api that returns
list of tags (instead of iterator), add a specific tag to the returned list and
create a new cell with existing tags + 1 new tag. Open for suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
