[ https://issues.apache.org/jira/browse/HBASE-5916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272673#comment-13272673 ]
Hadoop QA commented on HBASE-5916: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526389/HBASE-5916_trunk_4.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.TestDrainingServer org.apache.hadoop.hbase.regionserver.TestRSKilledWhenMasterInitializing Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1836//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1836//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1836//console This message is automatically generated. > RS restart just before master intialization we make the cluster non operative > ----------------------------------------------------------------------------- > > Key: HBASE-5916 > URL: https://issues.apache.org/jira/browse/HBASE-5916 > Project: HBase > Issue Type: Bug > Affects Versions: 0.92.1, 0.94.0 > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Priority: Critical > Fix For: 0.94.1 > > Attachments: HBASE-5916_trunk.patch, HBASE-5916_trunk_1.patch, > HBASE-5916_trunk_1.patch, HBASE-5916_trunk_2.patch, HBASE-5916_trunk_3.patch, > HBASE-5916_trunk_4.patch > > > Consider a case where my master is getting restarted. RS that was alive when > the master restart started, gets restarted before the master initializes the > ServerShutDownHandler. > {code} > serverShutdownHandlerEnabled = true; > {code} > In this case when the RS tries to register with the master, the master will > try to expire the server but the server cannot be expired as still the > serverShutdownHandler is not enabled. > This case may happen when i have only one RS gets restarted or all the RS > gets restarted at the same time.(before assignRootandMeta). > {code} > LOG.info(message); > if (existingServer.getStartcode() < serverName.getStartcode()) { > LOG.info("Triggering server recovery; existingServer " + > existingServer + " looks stale, new server:" + serverName); > expireServer(existingServer); > } > {code} > If another RS is brought up then the cluster comes back to normalcy. > May be a very corner case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira