Apache9 commented on pull request #2748: URL: https://github.com/apache/hbase/pull/2748#issuecomment-743759517
> Skimmed. Looks good. Export somehow so could see pretty pictures would be sweet. Could be export be dump to a new hbase servlet traces page? For me I think first we could use the logging exporter to prove that the tracing actually works. And then, we could do two things in parallel. One is to implement tracing for different sub modules in HBase, especially that we need to pass the spans across rpc calls. The other is to use the other exporters such as zipkin or jaeger to show the tracing data with a more beautyful picture, and this should also be well documented in our ref guide to tell users how to make use the tracing data. > > Does the global trace just keep accumulating or does it start dropping traces after a while or size? Do you know? Thanks. It will just a noop Without depending on opentelemetry-sdk, the tracer is just a noop which does nothing. With opentelemetry-sdk, it depends on the Sampler. https://github.com/open-telemetry/opentelemetry-java/blob/master/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/samplers/Sampler.java AlwaysOn, AlwaysOff, RatioBased. It will then pass the spans to a SpanProcessor, and then to a SpanExporter. https://github.com/open-telemetry/opentelemetry-java/blob/master/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/SpanProcessor.java https://github.com/open-telemetry/opentelemetry-java/blob/master/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/export/SpanExporter.java Then you need to depend on different SpanExporters to actually export the spans to backend tracing system. See this section on the exporters currently supported. https://github.com/open-telemetry/opentelemetry-java/blob/master/QUICKSTART.md#exporter Tracing is a big picture. Hope this could make you understand better. Feel free to ask other questions. I'm new to this area and still need to learn a lot of things. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
