virajjasani commented on pull request #2809:
URL: https://github.com/apache/hbase/pull/2809#issuecomment-750383118


   > Above code is the test code, but i found that RPCServe still use admin user
   > 
   > _protected void requirePermission(String request, Permission.Action perm) 
throws IOException { if (accessChecker != null) { 
accessChecker.requirePermission(RpcServer.getRequestUser().orElse(null), 
request, null, perm); } }_
   > RpcServer.getRequestUser().orElse(null) returns admin user, not non-admin 
user, this would not happen in real clauster.
   > If someone could point the root cause, plese leave a comment.
   
   In real cluster, if user is not Admin, call `requirePermission(requestName, 
Permission.Action.ADMIN)` will fail anyways.
   If you are worried about using some other user as part of unit test, yeah 
maybe we need some help.
   
   Let's wait for some time, if we don't find a way to repro our scenario using 
non-admin user, we can commit core changes in Rpc implementation as is.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to