[ 
https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255763#comment-17255763
 ] 

shenshengli commented on HBASE-25449:
-------------------------------------

Because this is an HDFS client parameter, there are default values in 
HDFs-default.xml and explicit values in HDFs-site.xml, which HBase relies on.If 
THE HDFS is not explicitly set to on, use the HDFS default shutdown effect here 
as well.If HDFS is already explicitly set to on, and because of this default, 
hbase needs to be explicitly set to on, this can easily be ignored.Since open 
short circuit reading has been mentioned by many people as a way to improve 
performance, why have it set twice?

> 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml
> ---------------------------------------------------------------------
>
>                 Key: HBASE-25449
>                 URL: https://issues.apache.org/jira/browse/HBASE-25449
>             Project: HBase
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 2.0.1
>            Reporter: shenshengli
>            Assignee: shenshengli
>            Priority: Minor
>
> I think this parameter is not suitable for in hbase-default.xml, because in 
> this case, HDFS explicitly set to "dfs.client.read.shortcircuit=true", hbase 
> rely on HDFS configuration, the parameters in hbase service still is 
> false.Must be explicitly in hbase-site.xml is set to 
> "dfs.client.read.shortcircuit=true" to take effect.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to