ZhaoBQ commented on a change in pull request #2812:
URL: https://github.com/apache/hbase/pull/2812#discussion_r549545528
##########
File path:
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestTableDescriptorBuilder.java
##########
@@ -292,6 +347,13 @@ public void testStringCustomizedValues() {
"'testStringCustomizedValues', " +
"{TABLE_ATTRIBUTES => {DURABILITY => 'ASYNC_WAL'}}, {NAME => 'cf',
BLOCKSIZE => '1000'}",
htd.toStringCustomizedValues());
+
+ htd =
TableDescriptorBuilder.newBuilder(htd).setMaxFileSize("10737942528").build();
+ assertEquals(
+ "'testStringCustomizedValues', " +
+ "{TABLE_ATTRIBUTES => {DURABILITY => 'ASYNC_WAL', "
+ + "MAX_FILESIZE => '10737942528 B (10 GB 512 KB)'}}, {NAME => 'cf',
BLOCKSIZE => '1000'}",
Review comment:
I copied the pretty print format of TTL. But I‘m with you, the space is
not necessary. Will update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
