[ https://issues.apache.org/jira/browse/HBASE-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273703#comment-13273703 ]
nkeywal commented on HBASE-5992: -------------------------------- bq. What does the big refactoring of TestDrainingServer do? Hopefully it's now non flaky. Before both the test and the core code were a little bit flaky! :-). bq. In hbase code base, we have spaces around operators... i.e. this needs spaces Done. bq. does removeDeadNotExpiredServers also need to be? It does compile if it's package protected. I didn't dare doing it in the first patch to maintain the existing interface, but since you're asking :-). Done. TestDrainingServer failed for an unrelated reason in its setup. But well. Fixed (hopefully, I actually don't really reproduce the issue locally) as well in the next patch. > Generalization of region move implementation + manage draining servers in > bulk assign > ------------------------------------------------------------------------------------- > > Key: HBASE-5992 > URL: https://issues.apache.org/jira/browse/HBASE-5992 > Project: HBase > Issue Type: Bug > Components: master, regionserver > Affects Versions: 0.96.0 > Reporter: nkeywal > Assignee: nkeywal > Priority: Minor > Attachments: 5992.v2.patch > > > The region move implementation now has now a similar behavior whatever the > destination server is specified or not. This allows: > - to benefit from the improvement in HBASE-5877 > - as a side effect to have the coprocessors calls when the destination > server is not specified > > This includes various fixes around draining servers. Draining servers were > not excluded during a bulk assign. This is now fixed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira