lujiefsi commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-752420867
explain why UT fails and why make changes: (1) rpcPreCheck will first check whether server is online by _'isOnline'_ method, but HMaster do not have such method, so it always return false and hence throws exception "ServerNotRun....". So I add such _'isOnline'_ method in HMaster for test.(see its comments) (2)But we still have another problem, if we start two master, then backup master will never in online state, so updateConfiguration always throws exception "ServerNotRun....". So i remove online check and directly apply admin check for updateConfiguration(notes that even backup master are not online state, it still can handle rpc request, because its rpcserver has started) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
