Apache9 commented on a change in pull request #2825:
URL: https://github.com/apache/hbase/pull/2825#discussion_r550372045
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -832,7 +832,7 @@ private void finishActiveMasterInitialization(MonitoredTask
status) throws IOExc
HBaseFsck.createLockRetryCounterFactory(this.conf).create());
} finally {
if (result != null) {
- IOUtils.closeQuietly(result.getSecond());
+ Closeables.close(result.getSecond(), true);
Review comment:
For IOUtils.closeQuietly, now it provides a version with a consumer
parameter to process the IOException which is not deprecated.
For Closeables.closeQuirtly, the version which takes a Closeable as
parameter has already been removed for a long time, but the version which takes
a InputStream or a Reader is still available and is not deprecated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
