ndimiduk commented on a change in pull request #2806: URL: https://github.com/apache/hbase/pull/2806#discussion_r552247999
########## File path: dev-support/create-release/release-build.sh ########## @@ -136,19 +136,21 @@ if [[ "$1" == "tag" ]]; then git config user.name "$GIT_NAME" git config user.email "$GIT_EMAIL" + git config user.signingkey "${GPG_KEY}" # Create release version maven_set_version "$RELEASE_VERSION" + find . -name pom.xml -exec git add {} \; git add RELEASENOTES.md CHANGES.md - git commit -a -m "Preparing ${PROJECT} release $RELEASE_TAG; tagging and updates to CHANGES.md and RELEASENOTES.md" + git commit -s -m "Preparing ${PROJECT} release $RELEASE_TAG; tagging and updates to CHANGES.md and RELEASENOTES.md" log "Creating tag $RELEASE_TAG at the head of $GIT_BRANCH" - git tag "$RELEASE_TAG" + git tag -s -m "Via create-release" "$RELEASE_TAG" Review comment: In other projects, I used to use `release:prepare` to apply version change to the poms and create a release tag. A little configuration of the plugin lets you specify these details, it worked pretty well. I was never brave enough to let the plugin push changes though ; i always verified and pushed manually. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org