saintstack commented on a change in pull request #2754:
URL: https://github.com/apache/hbase/pull/2754#discussion_r552308847
##########
File path: dev-support/release-vm/README.md
##########
@@ -0,0 +1,63 @@
+# HBase Release Env
+
+This is a vagrant project that provides a virtual machine environment suitable
+for running an Apache HBase release.
+
+Requires:
+* VirtualBox
+* Vagrant
+* The private portion of your signing key avilable in the local GPG agent
+* The private portion of your Github authentication key available in the local
GPG agent
+
+## Usage
+
+Unlock the local keyring before proceeding (this should prompt you for your
GPG passphrase). For
+example, assuming you have an authentication key configured in your keyring,
this will do the
+trick.
+
+```sh
+$ ssh -T g...@github.com
+Hi <you>! You've successfully authenticated, but GitHub does not provide shell
access.
+```
+
+Export the public portion of your signing credentials where the guest VM can
access it,
+
+```sh
+$ gpg --export <you>@apache.org > gpg.<you>.apache.pub
Review comment:
I think whats missing here is that the cwd is ./release-vm so the .pub
is in an importable location and the vagrant up just works?
##########
File path: dev-support/release-vm/README.md
##########
@@ -0,0 +1,63 @@
+# HBase Release Env
+
+This is a vagrant project that provides a virtual machine environment suitable
+for running an Apache HBase release.
+
+Requires:
+* VirtualBox
+* Vagrant
+* The private portion of your signing key avilable in the local GPG agent
+* The private portion of your Github authentication key available in the local
GPG agent
+
+## Usage
+
+Unlock the local keyring before proceeding (this should prompt you for your
GPG passphrase). For
+example, assuming you have an authentication key configured in your keyring,
this will do the
+trick.
+
+```sh
+$ ssh -T g...@github.com
+Hi <you>! You've successfully authenticated, but GitHub does not provide shell
access.
+```
+
+Export the public portion of your signing credentials where the guest VM can
access it,
+
+```sh
+$ gpg --export <you>@apache.org > gpg.<you>.apache.pub
+```
+
+Launch the VM
+
+```sh
+$ vagrant up
+```
+
+Connect to the VM. This should forward your ssh- and gpg-agent session.
+
+```sh
+$ vagrant ssh
+```
+
+Now from the VM, import your identity and verify the gpg-agent passthrough is
working correctly.
+
+```sh
+$ gpg --no-autostart --import /vagrant/gpg.<you>.apache.pub
+...
+gpg: Total number processed: 1
+gpg: imported: 1
+$ gpg --no-autostart --detach --armor --sign repos/hbase/pom.xml
+$ gpg --no-autostart --verify repos/hbase/pom.xml.asc
+gpg: assuming signed data in 'repos/hbase/pom.xml'
+...
+$ ssh -T g...@github.com
Review comment:
Just to launch ssh agent? I need it?
##########
File path: dev-support/release-vm/README.md
##########
@@ -0,0 +1,63 @@
+# HBase Release Env
+
+This is a vagrant project that provides a virtual machine environment suitable
+for running an Apache HBase release.
+
+Requires:
+* VirtualBox
+* Vagrant
+* The private portion of your signing key avilable in the local GPG agent
+* The private portion of your Github authentication key available in the local
GPG agent
+
+## Usage
+
+Unlock the local keyring before proceeding (this should prompt you for your
GPG passphrase). For
+example, assuming you have an authentication key configured in your keyring,
this will do the
+trick.
+
+```sh
+$ ssh -T g...@github.com
+Hi <you>! You've successfully authenticated, but GitHub does not provide shell
access.
+```
+
+Export the public portion of your signing credentials where the guest VM can
access it,
+
+```sh
+$ gpg --export <you>@apache.org > gpg.<you>.apache.pub
+```
+
+Launch the VM
+
+```sh
+$ vagrant up
+```
+
+Connect to the VM. This should forward your ssh- and gpg-agent session.
+
+```sh
+$ vagrant ssh
+```
+
+Now from the VM, import your identity and verify the gpg-agent passthrough is
working correctly.
+
+```sh
+$ gpg --no-autostart --import /vagrant/gpg.<you>.apache.pub
+...
+gpg: Total number processed: 1
+gpg: imported: 1
+$ gpg --no-autostart --detach --armor --sign repos/hbase/pom.xml
+$ gpg --no-autostart --verify repos/hbase/pom.xml.asc
+gpg: assuming signed data in 'repos/hbase/pom.xml'
+...
+$ ssh -T g...@github.com
Review comment:
Why am I doing this?
##########
File path: dev-support/release-vm/README.md
##########
@@ -0,0 +1,63 @@
+# HBase Release Env
+
+This is a vagrant project that provides a virtual machine environment suitable
+for running an Apache HBase release.
+
+Requires:
+* VirtualBox
+* Vagrant
+* The private portion of your signing key avilable in the local GPG agent
+* The private portion of your Github authentication key available in the local
GPG agent
+
+## Usage
+
+Unlock the local keyring before proceeding (this should prompt you for your
GPG passphrase). For
+example, assuming you have an authentication key configured in your keyring,
this will do the
+trick.
+
+```sh
+$ ssh -T g...@github.com
+Hi <you>! You've successfully authenticated, but GitHub does not provide shell
access.
+```
+
+Export the public portion of your signing credentials where the guest VM can
access it,
+
+```sh
+$ gpg --export <you>@apache.org > gpg.<you>.apache.pub
+```
+
+Launch the VM
+
+```sh
+$ vagrant up
+```
+
+Connect to the VM. This should forward your ssh- and gpg-agent session.
+
+```sh
+$ vagrant ssh
+```
+
+Now from the VM, import your identity and verify the gpg-agent passthrough is
working correctly.
+
+```sh
+$ gpg --no-autostart --import /vagrant/gpg.<you>.apache.pub
+...
+gpg: Total number processed: 1
+gpg: imported: 1
+$ gpg --no-autostart --detach --armor --sign repos/hbase/pom.xml
Review comment:
Signing a new file, I did not have to provide my password... which is
good. I have a vm up that does not have my private key which is good.....
##########
File path: dev-support/release-vm/README.md
##########
@@ -0,0 +1,63 @@
+# HBase Release Env
+
+This is a vagrant project that provides a virtual machine environment suitable
+for running an Apache HBase release.
+
+Requires:
+* VirtualBox
+* Vagrant
+* The private portion of your signing key avilable in the local GPG agent
+* The private portion of your Github authentication key available in the local
GPG agent
+
+## Usage
+
+Unlock the local keyring before proceeding (this should prompt you for your
GPG passphrase). For
+example, assuming you have an authentication key configured in your keyring,
this will do the
+trick.
+
+```sh
+$ ssh -T g...@github.com
+Hi <you>! You've successfully authenticated, but GitHub does not provide shell
access.
+```
+
+Export the public portion of your signing credentials where the guest VM can
access it,
+
+```sh
+$ gpg --export <you>@apache.org > gpg.<you>.apache.pub
+```
+
+Launch the VM
+
+```sh
+$ vagrant up
+```
+
+Connect to the VM. This should forward your ssh- and gpg-agent session.
+
+```sh
+$ vagrant ssh
+```
+
+Now from the VM, import your identity and verify the gpg-agent passthrough is
working correctly.
+
+```sh
+$ gpg --no-autostart --import /vagrant/gpg.<you>.apache.pub
+...
+gpg: Total number processed: 1
+gpg: imported: 1
+$ gpg --no-autostart --detach --armor --sign repos/hbase/pom.xml
Review comment:
I had to resupply my password for my gpg key here. I didn't expect that.
I even logged out, reset my gpg agent with
gpgconf --kill all && gpg-connect-agent /bye
... signed something off the vm (which required me to fill in my
password)..... I then did vagrant ssh and had to provide password again.
##########
File path: dev-support/release-vm/README.md
##########
@@ -0,0 +1,63 @@
+# HBase Release Env
+
+This is a vagrant project that provides a virtual machine environment suitable
+for running an Apache HBase release.
+
+Requires:
+* VirtualBox
+* Vagrant
+* The private portion of your signing key avilable in the local GPG agent
+* The private portion of your Github authentication key available in the local
GPG agent
+
+## Usage
+
+Unlock the local keyring before proceeding (this should prompt you for your
GPG passphrase). For
+example, assuming you have an authentication key configured in your keyring,
this will do the
+trick.
+
+```sh
+$ ssh -T g...@github.com
+Hi <you>! You've successfully authenticated, but GitHub does not provide shell
access.
+```
+
+Export the public portion of your signing credentials where the guest VM can
access it,
+
+```sh
+$ gpg --export <you>@apache.org > gpg.<you>.apache.pub
+```
+
+Launch the VM
+
+```sh
+$ vagrant up
+```
+
+Connect to the VM. This should forward your ssh- and gpg-agent session.
+
+```sh
+$ vagrant ssh
+```
+
+Now from the VM, import your identity and verify the gpg-agent passthrough is
working correctly.
+
+```sh
+$ gpg --no-autostart --import /vagrant/gpg.<you>.apache.pub
+...
+gpg: Total number processed: 1
+gpg: imported: 1
+$ gpg --no-autostart --detach --armor --sign repos/hbase/pom.xml
Review comment:
I didn't expect to have to reprovide my gpg password if forwarding going
on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
