Apache9 commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-757076173
Oh, after checking the code, I remembered what I concerned was another problem... If we do not register our znode on zookeeper after calling regionServerStartup, there is no way for the master to mark this regionserver as dead so it will remain there forever. So I agree with @bharathv that, we should mark a region server as online after its first regionServerReport, instead of regionServerStartup, maybe we could have another map in ServerManager to record the region servers which have called regionServerStartup but no regionServerReport yet, and once there is a regionServerReport, we move it the actual active region server map and allow it to take regions. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
