[ 
https://issues.apache.org/jira/browse/HBASE-25505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17265138#comment-17265138
 ] 

Bharath Vissapragada commented on HBASE-25505:
----------------------------------------------

[~larsh] Thanks for narrowing it down the to the ReplicationLogCleaner. 
[~zhangduo] That makes sense to me, nice find. Agree that the cleanup needs to 
be made idempotent to avoid any issues in teardown. You want to spin up a patch 
or you want me to do it (or if anyone else wants to own it)..?

> ZK watcher threads are daemonized; reconsider
> ---------------------------------------------
>
>                 Key: HBASE-25505
>                 URL: https://issues.apache.org/jira/browse/HBASE-25505
>             Project: HBase
>          Issue Type: Brainstorming
>            Reporter: Andrew Kyle Purtell
>            Priority: Major
>         Attachments: ScheduledChore.cleanup-not-called.diff
>
>
> On HBASE-25279 there was some discussion and difference of opinion about 
> having ZK watcher pool threads be daemonized. This is not necessarily a 
> problem but should be reconsidered. 
> Daemon threads are subject to abrupt termination during JVM shutdown and 
> therefore may be interrupted before state changes are complete or resources 
> are released. 
> As long as ZK watchers are properly closed by shutdown logic the pool threads 
> will be terminated in a controlled manner and the JVM will exit. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to