saintstack commented on a change in pull request #2909:
URL: https://github.com/apache/hbase/pull/2909#discussion_r567331142
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1269,6 +1269,9 @@ private void startServiceThreads() throws IOException {
HConstants.MASTER_LOG_REPLAY_OPS_THREADS,
HConstants.MASTER_LOG_REPLAY_OPS_THREADS_DEFAULT));
this.service.startExecutorService(ExecutorType.MASTER_SNAPSHOT_OPERATIONS,
conf.getInt(
SnapshotManager.SNAPSHOT_POOL_THREADS_KEY,
SnapshotManager.SNAPSHOT_POOL_THREADS_DEFAULT));
+ this.service.startExecutorService(ExecutorType.MASTER_MERGE_OPERATIONS,
conf.getInt(
Review comment:
Are we starting up two threads here that will be sitting around doing
nothing for 99.9999999% of the time? Does the executor let all threads die if
not being used?
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/executor/EventType.java
##########
@@ -149,7 +149,7 @@
* C_M_MERGE_REGION<br>
* Client asking Master to merge regions.
*/
- C_M_MERGE_REGION (30, ExecutorType.MASTER_TABLE_OPERATIONS),
+ C_M_MERGE_REGION (30, ExecutorType.MASTER_MERGE_OPERATIONS),
Review comment:
One question that came to mind was if upping the size of the
TABLE_OPERATIONS pool would have been one way to alleviate your massive merge
blockage? (Rather than give it its own pool as here?)
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/executor/EventType.java
##########
@@ -149,7 +149,7 @@
* C_M_MERGE_REGION<br>
* Client asking Master to merge regions.
*/
- C_M_MERGE_REGION (30, ExecutorType.MASTER_TABLE_OPERATIONS),
+ C_M_MERGE_REGION (30, ExecutorType.MASTER_MERGE_OPERATIONS),
Review comment:
Poking around, I see there is specialization for open, close, snapshot,
so you are following a pattern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
