[
https://issues.apache.org/jira/browse/HBASE-5927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276610#comment-13276610
]
rajeshbabu commented on HBASE-5927:
-----------------------------------
bq.So I think we could modify a little for the
ServerShutdownHandler#processDeadRegion:
{code}
boolean disabling = assignmentManager.getZKTable().isDisablingTable(
hri.getTableNameAsString());
{code}
In this case we are not adding region info to toAssignRegions list no need to
remove from this list
{code}
toAssignRegions.remove(hri)
{code}
But even we return false in case of disabling/disabled there may be chance of
znode and rit present.
we need to wait until timeout monitor(present 30min.) to trigger unassign and
call
{code}
cancelClosingRegionIfDisabling(region)
{code}
Thats why we need to have below statements to remove rit and clear znode.
{code}
am.deleteClosingOrClosedNode(hri);
am.regionOffline(hri);
{code}
> SSH and DisableTableHandler happening together does not clear the znode of
> the region and RIT map.
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5927
> URL: https://issues.apache.org/jira/browse/HBASE-5927
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.92.1, 0.96.0, 0.94.1
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5927_94.patch, HBASE-5927_94_v2.patch,
> HBASE-5927_trunk.patch, HBASE-5927_trunk_2.patch, TestCaseForReProduce.txt
>
>
> A possible exception: If the related regionserver was just killed(But HMaster
> has not perceived that), then we will get a local exception "Connection reset
> by peer". If this region belongs to a disabling table. what will happen?
> ServerShutdownHandler will remove this region from AM#regions. So this region
> is still existing in RIT. TimeoutMonitor will take care of it after it got
> timeout. Then invoke unassign again. Since this region has been removed from
> AM#regions, it will return directly due to the below code:
> {code}
> synchronized (this.regions) {
> // Check if this region is currently assigned
> if (!regions.containsKey(region)) {
> LOG.debug("Attempted to unassign region " +
> region.getRegionNameAsString() + " but it is not " +
> "currently assigned anywhere");
> return;
> }
> }
> {code}
> Then it leads to an end-less loop.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
