[ 
https://issues.apache.org/jira/browse/HBASE-5959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276942#comment-13276942
 ] 

Phabricator commented on HBASE-5959:
------------------------------------

eclark has commented on the revision "HBASE-5959 [jira] Add other load 
balancers".

  I'll get the config storing in the next version

INLINE COMMENTS
  
src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:241
 There are already config paramaters with balancer.<configName>  we should keep 
the hierarchy.
  
src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:256
 And I actually think it should be given a lower weight as the table cost is 
something that represents an on going cost to the cluster and the locality cost 
is a one time transfer.  The impetus for doing this work was that we saw 
production clusters that were no balancing because the old balancer did not 
want to move regions around to balance the number of regions per table 
(Something I've seen on several different production clusters now; a real issue 
on anything that has big batch jobs).  Placing locality's weight above table 
cost would just mean that the same thing could happen.

  However I think the middle ground combined with the ability to change  per 
install is enough without testing on production clusters.
  
src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:251
 Nope I'll add that in my next version.

REVISION DETAIL
  https://reviews.facebook.net/D3189

To: JIRA, eclark
Cc: tedyu

                
> Add other load balancers
> ------------------------
>
>                 Key: HBASE-5959
>                 URL: https://issues.apache.org/jira/browse/HBASE-5959
>             Project: HBase
>          Issue Type: New Feature
>          Components: master
>    Affects Versions: 0.96.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>         Attachments: HBASE-5959-0.patch, HBASE-5959-1.patch, 
> HBASE-5959-2.patch, HBASE-5959-3.patch, HBASE-5959-6.patch, 
> HBASE-5959-7.patch, HBASE-5959.D3189.1.patch, HBASE-5959.D3189.2.patch, 
> HBASE-5959.D3189.3.patch, HBASE-5959.D3189.4.patch
>
>
> Now that balancers are pluggable we should give some options.b

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to