[
https://issues.apache.org/jira/browse/HBASE-6018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277920#comment-13277920
]
Lars Hofhansl commented on HBASE-6018:
--------------------------------------
The change is fine. I was just pointing out the executor weirdness.
>From your quoted text...
bq. If corePoolSize or more threads are running, the Executor always prefers
queuing a request rather than adding a new thread
Since LinkedBlockingQueue is unbounded the executor will *never* grow the
number of threads past the number of core threads specified (re-read the doc if
you don't believe me :) ). This is certainly not what you want although in the
case of HBCK it does not matter, as you're not enqueuing 100000's of tasks.
At least the matching change should be to set core threads and max threads to
the same value (in order to avoid later confusion).
> hbck fails with a RejectedExecutionException
> --------------------------------------------
>
> Key: HBASE-6018
> URL: https://issues.apache.org/jira/browse/HBASE-6018
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1, 0.94.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-6018-v2.patch, hbase-6018.patch
>
>
> On a long running job 0.94.0rc3 cluster, we get to a point where hbck
> consistently encounters this error and fails:
> {code}
> Exception in thread "main" java.util.concurrent.RejectedExecutionException
> at
> java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:1768)
> at
> java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:767)
> at
> java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:658)
> at
> org.apache.hadoop.hbase.util.HBaseFsck.loadHdfsRegionInfos(HBaseFsck.java:633)
> at
> org.apache.hadoop.hbase.util.HBaseFsck.onlineConsistencyRepair(HBaseFsck.java:354)
> at org.apache.hadoop.hbase.util.HBaseFsck.onlineHbck(HBaseFsck.java:382)
> at org.apache.hadoop.hbase.util.HBaseFsck.main(HBaseFsck.java:3120)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
