saintstack commented on a change in pull request #2769:
URL: https://github.com/apache/hbase/pull/2769#discussion_r599997634
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
##########
@@ -176,7 +176,7 @@ private void testSanity(final String testName) throws
Exception {
@Test
public void testRegionAssignmentAfterMasterRecoveryDueToZKExpiry() throws
Exception {
MiniHBaseCluster cluster = TEST_UTIL.getHBaseCluster();
- cluster.startRegionServer();
+ cluster.startRegionServerAndWait(2000);
Review comment:
Thanks @bharathv ... I'd think RS#online should change as part of this
patch else we'll all be confused going forward around what 'online' means.
`and both time out if the rs cannot be found within that list within the
given timeout. `
Why does it timeout do you think @caroliney14 ? Its not something like
foreground thread holding up the RS startup?
(This is a nice PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
