virajjasani commented on a change in pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#discussion_r603840821
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java
##########
@@ -90,6 +90,10 @@ public void shutdown() {
super.shutdown();
MetricsCoprocessor.removeRegistry(this.metricRegistry);
}
+
+ @Override public String toString() {
Review comment:
Is `toString()` also required for `WALCoprocessorHost`?
##########
File path: hbase-client/pom.xml
##########
@@ -72,6 +72,10 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
+ <dependency>
Review comment:
Hmm, it's not just server but client too can't live without it.
##########
File path:
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/ObserverContextImpl.java
##########
@@ -87,19 +89,5 @@ public boolean shouldBypass() {
return Optional.ofNullable(caller);
}
- /**
- * Instantiates a new ObserverContext instance if the passed reference is
<code>null</code> and
- * sets the environment in the new or existing instance. This allows
deferring the instantiation
- * of a ObserverContext until it is actually needed.
- * @param <E> The environment type for the context
- * @param env The coprocessor environment to set
- * @return An instance of <code>ObserverContext</code> with the environment
set
- */
- @Deprecated
Review comment:
We are good to remove this in 2.x releases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
