wchevreuil commented on a change in pull request #3104:
URL: https://github.com/apache/hbase/pull/3104#discussion_r603883180
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALFactory.java
##########
@@ -311,7 +311,7 @@ public Reader createReader(final FileSystem fs, final Path
path,
reader.init(fs, path, conf, stream);
return reader;
}
- } catch (IOException e) {
+ } catch (Exception e) {
Review comment:
Catching `Exception` is enough? No need to catch `Throwable` to avoid
any possibility of still getting this leak?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
