[
https://issues.apache.org/jira/browse/HBASE-25713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312764#comment-17312764
]
Michael Stack commented on HBASE-25713:
---------------------------------------
I pushed up my latest changes to the branch and updated the PR. I think this
experiment is done. See below for what I was able to break out for an
hbase-coprocessor and hbase-wal module. Neither is coherent enough to earn
their names....
hbase-coprocessor has a few of the base classes in it only and no tests to
speak of:
{{hbase-coprocessor/src/test/java/org/apache/hadoop/hbase/coprocessor/TestReadOnlyConfiguration.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/CoprocessorEnvironment.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEnvironment.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/MetricsCoprocessor.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/ObserverContext.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/ObserverContextImpl.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/CoreCoprocessor.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/ReadOnlyConfiguration.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/Coprocessor.java}}
Can't move anything else because needs internals context.
For the hbase-wal, I was not able to move an actual implementation. They are
too entwined in rpc and region. Here is what I was able to break out:
{{hbase-wal/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestMetricsWAL.java
hbase-wal/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestMetricsWALSource.java
hbase-wal/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestCustomWALCellCodec.java
hbase-wal/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestMetricsWALSourceImpl.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/wal/WALProvider.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/wal/WALKey.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/wal/WALKeyImpl.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/wal/DisabledWALProvider.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/wal/WAL.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/wal/WALEdit.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/coprocessor/WALCoprocessorEnvironment.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/coprocessor/WALCoprocessor.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/coprocessor/WALObserver.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FailedLogCloseException.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/MetricsWAL.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALActionsListener.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/MetricsWALSource.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/DamagedWALException.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/MetricsWALSourceImpl.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/SequenceId.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALFileLengthProvider.java}}
Its not enough I think for the module to be called the hbase-wal module.
> Make an hbase-wal module
> ------------------------
>
> Key: HBASE-25713
> URL: https://issues.apache.org/jira/browse/HBASE-25713
> Project: HBase
> Issue Type: Sub-task
> Reporter: Michael Stack
> Priority: Major
>
> Extract an hbase-wal module upon which hbase-server can depend; makes
> hbase-server smaller and maybe we could do an hbase-wal standalone... This is
> an experiment.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
