[ 
https://issues.apache.org/jira/browse/HBASE-25792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Stack updated HBASE-25792:
----------------------------------
    Description: 
Hadoop 3.3.1 (unreleased currently) shades guava. The shaded guava then trips 
the check in our shading that tries to exclude hadoop bits from the fat jars we 
build.

For the issue to trigger, need to build against tip of hadoop branch-3.3. You 
then get this complaint:

{code}
[INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ 
hbase-shaded-check-invariants ---
[ERROR] Found artifact with unexpected contents: 
'/Users/stack/.m2/repository/org/apache/hbase/hbase-shaded-mapreduce/2.3.6-SNAPSHOT/hbase-shaded-mapreduce-2.3.6-SNAPSHOT.jar'
    Please check the following and either correct the build or update
    the allowed list with reasoning.

    org/apache/hadoop/thirdparty/
    org/apache/hadoop/thirdparty/com/
    org/apache/hadoop/thirdparty/com/google/
    org/apache/hadoop/thirdparty/com/google/common/
    org/apache/hadoop/thirdparty/com/google/common/annotations/
    org/apache/hadoop/thirdparty/com/google/common/annotations/Beta.class
    
org/apache/hadoop/thirdparty/com/google/common/annotations/GwtCompatible.class
    
org/apache/hadoop/thirdparty/com/google/common/annotations/GwtIncompatible.class
    
org/apache/hadoop/thirdparty/com/google/common/annotations/VisibleForTesting.class
    org/apache/hadoop/thirdparty/com/google/common/base/
    org/apache/hadoop/thirdparty/com/google/common/base/Absent.class
    org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$1.class
    
org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$State.class
    org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator.class
    org/apache/hadoop/thirdparty/com/google/common/base/Ascii.class
    org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$1.class
    org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$2.class
    org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$3.class
    org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$4.class

....
{code}

  was:
Hadoop 3.3.1 (unreleased currently) shades guava. The shaded guava then trips 
the check in our shading that tries to exclude hadoop bits from the fat jars we 
build.

For the issue to trigger, need to build against tip of hadoop branch-3.3.


> Filter out o.a.hadoop.thirdparty building shaded jars
> -----------------------------------------------------
>
>                 Key: HBASE-25792
>                 URL: https://issues.apache.org/jira/browse/HBASE-25792
>             Project: HBase
>          Issue Type: Bug
>          Components: shading
>    Affects Versions: 3.0.0-alpha-1, 2.5.0, 2.4.3
>            Reporter: Michael Stack
>            Assignee: Michael Stack
>            Priority: Major
>
> Hadoop 3.3.1 (unreleased currently) shades guava. The shaded guava then trips 
> the check in our shading that tries to exclude hadoop bits from the fat jars 
> we build.
> For the issue to trigger, need to build against tip of hadoop branch-3.3. You 
> then get this complaint:
> {code}
> [INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ 
> hbase-shaded-check-invariants ---
> [ERROR] Found artifact with unexpected contents: 
> '/Users/stack/.m2/repository/org/apache/hbase/hbase-shaded-mapreduce/2.3.6-SNAPSHOT/hbase-shaded-mapreduce-2.3.6-SNAPSHOT.jar'
>     Please check the following and either correct the build or update
>     the allowed list with reasoning.
>     org/apache/hadoop/thirdparty/
>     org/apache/hadoop/thirdparty/com/
>     org/apache/hadoop/thirdparty/com/google/
>     org/apache/hadoop/thirdparty/com/google/common/
>     org/apache/hadoop/thirdparty/com/google/common/annotations/
>     org/apache/hadoop/thirdparty/com/google/common/annotations/Beta.class
>     
> org/apache/hadoop/thirdparty/com/google/common/annotations/GwtCompatible.class
>     
> org/apache/hadoop/thirdparty/com/google/common/annotations/GwtIncompatible.class
>     
> org/apache/hadoop/thirdparty/com/google/common/annotations/VisibleForTesting.class
>     org/apache/hadoop/thirdparty/com/google/common/base/
>     org/apache/hadoop/thirdparty/com/google/common/base/Absent.class
>     
> org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$1.class
>     
> org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$State.class
>     org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator.class
>     org/apache/hadoop/thirdparty/com/google/common/base/Ascii.class
>     org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$1.class
>     org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$2.class
>     org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$3.class
>     org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$4.class
> ....
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to