wchevreuil commented on a change in pull request #3202:
URL: https://github.com/apache/hbase/pull/3202#discussion_r621026222
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -705,6 +705,17 @@ void majorCompact(TableName tableName, byte[]
columnFamily, CompactType compactT
Map<ServerName, Boolean> compactionSwitch(boolean switchState, List<String>
serverNamesList)
throws IOException;
+ /**
+ * Turn the compaction offload on or off. This state is ephemeral. The
setting will be lost on
+ * restart.
+ * @param switchState Set to <code>true</code> to enable, <code>false</code>
to disable.
+ * @param serverNamesList list of region servers.
+ * @return Previous compaction offload states for region servers
+ * @throws IOException if a remote or network exception occurs
+ */
+ Map<ServerName, Boolean> compactionOffloadSwitch(boolean switchState,
List<String> serverNamesList)
Review comment:
Why adding a separate API? We'll either have embedded or offload
compaction configured to run, so the existing `compactionSwitch` command should
transparently switch on/off whatever compaction execution strategy is in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
