wchevreuil commented on a change in pull request #3232:
URL: https://github.com/apache/hbase/pull/3232#discussion_r632524231
##########
File path:
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java
##########
@@ -135,9 +135,7 @@ public CellWritableComparable(Cell kv) {
@Override
public void write(DataOutput out) throws IOException {
- out.writeInt(PrivateCellUtil.estimatedSerializedSizeOfKey(kv));
- out.writeInt(0);
- PrivateCellUtil.writeFlatKey(kv, out);
+ KeyValueUtil.write(new KeyValue(kv), out);
Review comment:
Ok, so how about the other option I mentioned in my last comment:
>Maybe we would also need to change Import.readFields to stay aligned with
HBASE-18649 (I guess we could use CellBuilder to construct a Cell directly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
