[ 
https://issues.apache.org/jira/browse/HBASE-6061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280583#comment-13280583
 ] 

Hadoop QA commented on HBASE-6061:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12528508/HBASE-6061-0.92.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to introduce 33 new Findbugs (version 
1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.replication.TestReplication
                  
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
                  org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
                  org.apache.hadoop.hbase.replication.TestMasterReplication

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1951//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1951//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1951//console

This message is automatically generated.
                
> Fix ACL "Admin" Table inconsistent permission check
> ---------------------------------------------------
>
>                 Key: HBASE-6061
>                 URL: https://issues.apache.org/jira/browse/HBASE-6061
>             Project: HBase
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>              Labels: acl, security
>             Fix For: 0.92.2, 0.96.0, 0.94.1
>
>         Attachments: HBASE-6061-0.92.patch, HBASE-6061-v0.patch, 
> HBASE-6061-v1.patch
>
>
> the requirePermission() check for "admin" operation on a table is currently 
> inconsistent.
> Table Owner with CREATE rights (that means, the owner has created that table) 
> can enable/disable and delete the table but needs ADMIN rights to 
> add/remove/modify a column.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to