wchevreuil commented on a change in pull request #3298:
URL: https://github.com/apache/hbase/pull/3298#discussion_r638893713



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFlushContext.java
##########
@@ -29,15 +29,25 @@
  * A store flush context carries the state required to prepare/flush/commit 
the store's cache.
  */
 @InterfaceAudience.Private
-interface StoreFlushContext {
+public abstract class StoreFlushContext {
+
+  protected HStore store;
+  protected long cacheFlushSeqNum;
+  protected FlushLifeCycleTracker tracker;
+
+  public StoreFlushContext(HStore store, Long cacheFlushSeqNum, 
FlushLifeCycleTracker tracker){

Review comment:
       Could do it. The idea was just to move what was already implemented as 
an HStore inner class to its own outer class, as we would already benefit from 
extending it for the specific persisted store flush context.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to