wchevreuil commented on a change in pull request #88:
URL: 
https://github.com/apache/hbase-operator-tools/pull/88#discussion_r639534992



##########
File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBaseFsck.java
##########
@@ -1535,7 +1535,7 @@ private void loadHdfsRegioninfo(HbckInfo hbi) throws 
IOException {
       return;
     }
 
-    FileSystem fs = FileSystem.get(getConf());
+    FileSystem fs = FSUtils.getCurrentFileSystem(getConf());

Review comment:
       We should refrain from using hbase's `InterfaceAudience.Private` classes 
such as `FSUtils` in operator tools. We had problems in the past related to 
compatibility breaks. For that reason we had created `HBCKFSUtils` in operator 
tools. Please use this `HBCKFSUtils`, if the method you are depending on 
doesn't yet exist, please implement it there (or simply copy it from `FSUtils` 
there).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to