nyl3532016 commented on a change in pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#discussion_r640255301



##########
File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
##########
@@ -253,6 +256,12 @@ private void init(final int nMasterNodes, final int 
numAlwaysStandByMasters,
         hbaseCluster.addRegionServer(rsConf, i, user);
       }
 
+      // manually add the compaction servers as other users
+      for (int i = 0; i < numCompactionServers; i++) {

Review comment:
       Think twice, ITBLL need cover compaction server role, HBaseCluster has 
three types of cluster deployments: 
`MiniHBaseCluster`,`DistributedHBaseCluster`,`ProcessBasedLocalHBaseCluster`, 
all these classes should handle compaction server, maybe replication server 
also. So, It is better to integrate compaction server to `MiniHBaseCluster` for 
now? @saintstack 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to